Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the boolean attributes to checkbox and textarea helper methods. #955

Merged
merged 4 commits into from
Oct 23, 2019

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #952

Description

Adds the ability to set boolean attributes attrs: [:required] on textarea and checkbox methods.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this :D Just one suggestion for keeping duplication down

src/lucky/tags/input_helpers.cr Outdated Show resolved Hide resolved
@paulcsmith
Copy link
Member

Looks good!

@paulcsmith paulcsmith merged commit 921b7bb into master Oct 23, 2019
@paulcsmith paulcsmith deleted the issues/952 branch October 23, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

textarea does not accept boolean attributes
2 participants