Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing inline docs for time helpers #943

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Add missing inline docs for time helpers #943

merged 1 commit into from
Oct 22, 2019

Conversation

vlazar
Copy link
Contributor

@vlazar vlazar commented Oct 10, 2019

I've noticed time helpers are missing inline docs (#275).

jwoertink
jwoertink approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Looks like the docs you added in the website, so good for me.

@paulcsmith
Copy link
Member

Looks great! Thank you

@paulcsmith paulcsmith merged commit 6ae6ab1 into luckyframework:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlazar @paulcsmith @jwoertink