Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shell scripts POSIX-compliant #879

Merged
merged 1 commit into from
Aug 25, 2019
Merged

Make shell scripts POSIX-compliant #879

merged 1 commit into from
Aug 25, 2019

Conversation

j8r
Copy link
Contributor

@j8r j8r commented Aug 25, 2019

Purpose

Fixes #878
It converts bash scripts to POSIX compliant ones, in order to run them in any other OS without bash like Alpine (even if we can install it).

Description

Bashisms were removed or converted to POSIX-compliant syntax.
I have also added minor improvements, mainly stylistic (but not opinionated). I can explain if there are questions about them.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

Copy link
Member

@edwardloveall edwardloveall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j8r Thanks for trying to make this more accessible! I'm not s POSIX expert and had a couple of questions that I was hoping you could answer. In general, I approve of this change, I'm just mostly surprised that the set / pwd syntax needed to change.

script/precompile_tasks Show resolved Hide resolved
script/precompile_tasks Show resolved Hide resolved
Copy link
Member

@edwardloveall edwardloveall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@edwardloveall edwardloveall merged commit 6f08454 into luckyframework:master Aug 25, 2019
@j8r j8r deleted the make-shell-scripts-posix branch August 25, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bash in built-in tasks ?
3 participants