Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separating the helper methods #820

Merged
merged 2 commits into from
Jun 19, 2019
Merged

separating the helper methods #820

merged 2 commits into from
Jun 19, 2019

Conversation

jwoertink
Copy link
Member

Purpose

fixes #791

Description

Now that we have a distinction between helper methods that return String VS ones that actually return Nil because they write to the view directly, we can separate these methods out in to their own modules. This will make it easier for people to decipher which ones do what. As well as documentation.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thought. Up to you though! LGTM when you’re ready

src/lucky/page_helpers/html_helpers.cr Outdated Show resolved Hide resolved
@jwoertink jwoertink merged commit b27993c into luckyframework:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splitting up page helpers
2 participants