Adding support for an AssetHost

[russ]

Added an asset_host option to the Lucky::Server.settings
That setting is prepended to the asset path. It can be configured in the
application the same way host and port are.

Purpose

Adding an asset_host option provides a reasonable way to configure production apps to use a cdn for assets.

fixes #794

Description

Lucky::Server.configure do |settings|
  if Lucky::Env.production?
    settings.asset_host = "production.com"
  else
    settings.asset_host = "/"
  end
end

Checklist

• - An issue already exists detailing the issue/or feature request that this PR fixes
• - All specs are formatted with crystal tool format spec src
• [NA] - Inline documentation has been added and/or updated
• - Lucky builds on docker with ./script/setup
• - All builds and specs pass on docker with ./script/test

[jwoertink]

Looks like the failure is related to ameba updating to only support crystal 0.29.0, and Lucky running on an earlier version.

[russ]

Yeah, that is a versioning error. Should Lucky be locked to a specific version of Ameba or should this pr wait until Lucky is upgraded to 0.29.0?

[jwoertink]

I think we need to lock all shards down to very specific versions. It's a bit more restrictive, but there's nothing worse than running shards update, and everything is borked due to some random update. (e.g. this...)

[paulcsmith]

Yeah I think this is a great idea. Feel free to lock ameba to an older version in shard.yml to get this passing. Will try to take a closer look soon!

…

On Jun 7, 2019, at 1:41 PM, Jeremy Woertink ***@***.***> wrote: I think we need to lock all shards down to very specific versions. It's a bit more restrictive, but there's nothing worse than running shards update, and everything is borked due to some random update. (e.g. this...) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#795?email_source=notifications&email_token=AAAFO6TOEJOMRPGPWANENX3PZKMVVA5CNFSM4HVYZY72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXGQK7I#issuecomment-499975549>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAFO6VXHO5HXEIVVNW52CLPZKMVVANCNFSM4HVYZY7Q>.

[russ]

I added some specs around that. Still failing on the ameba version though.

[jwoertink]

Just lock it to 0.9.1 here https://github.com/luckyframework/lucky/blob/master/shard.yml#L63. Then the next version we roll out, we'll update that to 0.10.0

[paulcsmith]

I love it!