Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes allowing a symbol for status in a redirect. #730

Merged
merged 4 commits into from
Mar 18, 2019
Merged

Fixes allowing a symbol for status in a redirect. #730

merged 4 commits into from
Mar 18, 2019

Conversation

jwoertink
Copy link
Member

Fixes #729

The only relevant change here is adding a type to status. That forces the compiler to use the enum one. I moved that method override up thinking it was an order thing at first. I left it since it made sense. It calls the method below it.

Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect. Just a few suggestions for improving the documentation while you're in here.

Thank you :D

spec/lucky/action_rendering_spec.cr Show resolved Hide resolved
src/lucky/redirectable.cr Show resolved Hide resolved
src/lucky/redirectable.cr Outdated Show resolved Hide resolved
src/lucky/redirectable.cr Show resolved Hide resolved
src/lucky/redirectable.cr Outdated Show resolved Hide resolved
src/lucky/redirectable.cr Outdated Show resolved Hide resolved
Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@paulcsmith paulcsmith merged commit 580b28d into luckyframework:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants