Add Lucky::Routable.url_without_query_params
#662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hibachrach
force-pushed
the
hib-add-url-without-query-params
branch
from
f3ee97e to
42423a9
Compare
hibachrach
force-pushed
the
hib-add-url-without-query-params
branch
from
42423a9 to
d8f63d5
Compare
paulcsmith
approved these changes
Jan 4, 2019
| {% for param in path_params %} | ||
| {{ param.gsub(/:/, "").id }}, | ||
| {% end %} | ||
| ) |
There was a problem hiding this comment.
I wish I knew of a good way to DRY up macros like this, but I don't know of a way :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #407
I broke up
Lucky::Routable.routebecause it seemed to be getting a bit long.If anyone has any tips on DRYing up
{% for param in path_params %} {{ param.gsub(/:/, "").id }} {% end %}for defining arguments, that would be much appreciated!