Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate nil values correctly in JSON param fetching #1762

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

stephendolan
Copy link
Member

Purpose

Describe the feature or issue and link to the related issue.
If no issue has been opened about this, be sure to open an issue first to discuss the need for this PR.

Description

Please include any relevant code samples or screen shots that may help to overview of this PR.
Link to specific lines of code, or examples if you need to.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@stephendolan stephendolan changed the title Accommodate nil values correctly in JSON param fetching. Accommodate nil values correctly in JSON param fetching Dec 14, 2022
@jwoertink
Copy link
Member

This is probably fine. I think to really test it, we would have to tell Avram to point to main branch, then write the spec in Avram that tests this whole deal.

@stephendolan
Copy link
Member Author

@jwoertink I actually pulled this functionality down into the helper so there's no inconsistency when this is used by other methods in the same file. It still fixes the API client failure I was seeing and passes our test suite. 🥳

Agreed that we should test this in some way, but I'm not even sure where to start :(

@jwoertink
Copy link
Member

Good enough for me! Thanks for fixing it 🚀

@stephendolan stephendolan merged commit c70b972 into main Dec 15, 2022
@stephendolan stephendolan deleted the sd-json-params-fix branch December 15, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants