Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add attrs as parameter to submit helper #1759

Merged
merged 1 commit into from
Nov 28, 2022
Merged

add attrs as parameter to submit helper #1759

merged 1 commit into from
Nov 28, 2022

Conversation

jcads
Copy link
Contributor

@jcads jcads commented Nov 9, 2022

Purpose

Fixes #1758

Description

add attrs to submit helper, then it is passed down into the input

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src

@matthewmcgarvey matthewmcgarvey merged commit c033bd1 into luckyframework:main Nov 28, 2022
@jcads jcads deleted the submit-attrs branch June 7, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmcgarvey matthewmcgarvey matthewmcgarvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

submit helper does not accept attrs
2 participants
@jcads @matthewmcgarvey