Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the exec editor by env var. #1715

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Allow setting the exec editor by env var. #1715

merged 1 commit into from
Aug 14, 2022

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1698

Description

This allows you to set your editor using an env var ENV["EDITOR"] when running exec.

Now you can set it 3 different ways:

# project widde
Lucky::Exec.configure do |settings|
  settings.editor = "mate"
end

# CLI arg
lucky exec -e mate

# ENV var
EDITOR=mate lucky exec

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@jwoertink jwoertink merged commit d2f4fc3 into main Aug 14, 2022
@jwoertink jwoertink deleted the issues/1698 branch August 14, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When run lucky exec, get vim: command not found error.
2 participants