Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing references to habitat settings #1686

Merged
merged 2 commits into from
Apr 17, 2022
Merged

Fixing references to habitat settings #1686

merged 2 commits into from
Apr 17, 2022

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1685

Description

When a module creates a Habitat config, it will create both an instance and a class method called settings. If you include more than 1 module with habitat settings, then the last included one ends up overriding the previous ones.

This fixes the two areas where these could collide.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@jwoertink jwoertink merged commit 99d713c into main Apr 17, 2022
@jwoertink jwoertink deleted the issues/1685 branch April 17, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading to 0.30.0 causes error in Lucky::Subdomain settings
1 participant