Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new security header for Content-Security-Policy. #1673

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1664

Description

This PR adds a new Security module to set the Content-Security-Policy header.

/cc. @bararchy

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

Copy link

@bararchy bararchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🎉

Copy link
Member

@matthewmcgarvey matthewmcgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we'd want users to set themselves or could we update the BrowserAction in lucky-cli with this?

@jwoertink
Copy link
Member Author

hmmm 🤔 Part of me feels like this could be added by users individually since we've never had it before... but I also kind of feel like we could add it and it would fix crystal-loot/exception_page#17 ? maybe also related #1324

@jwoertink jwoertink merged commit 3b7424b into main Mar 6, 2022
@jwoertink jwoertink deleted the issues/1664 branch March 6, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Content-Security-Policy Header
3 participants