Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the build.release task. Use shards build instead. #1612

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

jwoertink
Copy link
Member

@jwoertink jwoertink commented Nov 15, 2021

Purpose

Fixes #1564
Closes #1593

Description

Originally this task ran the crystal build --release ./src/start_server.cr -o ./bin/start_server command for you. That was a really long command to run, so running lucky build.release was a lot easier to remember.

I wanted to just update this task to use shards build instead because if you have more than 1 binary for your app (i.e. workers, etc...), then this task wouldn't really work anyway. In fact, the heroku buildpack doesn't use it either for that reason.

I ended up deciding to just remove it because when I started updating it, I realized I would want to print which binaries were built, and that required parsing YAML. Then there was a spec file which wouldn't work without creating a whole temp project. Really in the end, shards build --production --release is pretty short, and more flexible.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@jwoertink jwoertink added the BREAKING CHANGE This will cause a breaking change label Nov 15, 2021
@jwoertink jwoertink merged commit 10b19c4 into master Nov 15, 2021
@jwoertink jwoertink deleted the issues/1564 branch November 15, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This will cause a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the release task to use shards build
2 participants