remove the build.release task. Use shards build instead. #1612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1564
Closes #1593
Description
Originally this task ran the
crystal build --release ./src/start_server.cr -o ./bin/start_server
command for you. That was a really long command to run, so runninglucky build.release
was a lot easier to remember.I wanted to just update this task to use
shards build
instead because if you have more than 1 binary for your app (i.e. workers, etc...), then this task wouldn't really work anyway. In fact, the heroku buildpack doesn't use it either for that reason.I ended up deciding to just remove it because when I started updating it, I realized I would want to print which binaries were built, and that required parsing YAML. Then there was a spec file which wouldn't work without creating a whole temp project. Really in the end,
shards build --production --release
is pretty short, and more flexible.Checklist
crystal tool format spec src
./script/setup
./script/test