Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile error #1582

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Fix compile error #1582

merged 1 commit into from
Sep 23, 2021

Conversation

akadusei
Copy link
Contributor

@akadusei akadusei commented Sep 23, 2021 •
edited
Loading

Closes #1579.

Calls to Lucky::Routable.route failed to compile when passed optional path param values other than strings.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@akadusei
Fix compile error
e72af72 
Closes #1579.

Calls to `Lucky::Routable.route` failed to compile when passed
optional path param values other than strings.
jwoertink
jwoertink approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! Thanks for fixing this, and catching the issue.

@jwoertink jwoertink merged commit 48dd0b1 into luckyframework:master Sep 23, 2021
@akadusei akadusei deleted the fix/1579 branch September 23, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing optional param to Lucky::Routable.with leads to compile error
2 participants
@akadusei @jwoertink