Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Officially deprecating route and nested_route #1510

Merged
merged 1 commit into from
May 28, 2021
Merged

Officially deprecating route and nested_route #1510

merged 1 commit into from
May 28, 2021

Conversation

jwoertink
Copy link
Member

Purpose

Ref: #789

Description

The route and nested_route were extracted in to a separate shard https://github.com/matthewmcgarvey/lucky_legacy_routing. This PR officially makes these macros deprecated, as well as removes all of the references in docs and specs.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@jwoertink
Officially deprecating and removing references to the route and neste…
00c5c02 
…d_route routing methods. These are available in a shard.
@jwoertink jwoertink merged commit d976793 into master May 28, 2021
@jwoertink jwoertink deleted the remove_dynamic_route_references branch May 28, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmcgarvey matthewmcgarvey matthewmcgarvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwoertink @matthewmcgarvey