Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new module to disable FLoC #1508

Merged
merged 1 commit into from
May 28, 2021
Merged

Added new module to disable FLoC #1508

merged 1 commit into from
May 28, 2021

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1486

Description

This adds a new module to optionally disable FLoC. Just include it in your app, and it will set the appropriate header.

class BrowserAction < Lucky::Action
  include Lucky::SecureHeaders::DisableFLoC
end

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@matthewmcgarvey
Copy link
Member

@jwoertink The connected issue was to disable FLoC by default. What are your thoughts on that?

@jwoertink
Copy link
Member Author

Reading around at a few articles, it seems like this is just a google experiment that probably won't last, or may change. I wouldn't be surprised if this is removed by the holidays 😂

We can still do it by default by adding this module in to generated apps. Then if people want to opt in to this disable, they can just add the module in their BrowserAction for upgrades.

Copy link
Member

@edwardloveall edwardloveall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be great to disable by default 🙂 It feels like the right thing to do and we want to be "batteries included" where it makes sense. I think it makes sense here!

@jwoertink
Copy link
Member Author

ok, issue on CLI opened up! 👍

@jwoertink jwoertink merged commit efa7376 into master May 28, 2021
@jwoertink jwoertink deleted the issues/1486 branch May 28, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable FLoC by default
4 participants