added DeleteOperation to delete action

[nodeMD]

Purpose

Fixes #1487

Description

added DeleteOperation to delete action
@jwoertink I am pretty sure that it is not as easy as that change that I've added but I would like to work on it so if it is not enough then could you please give me more guidance and direct me where I can find information to fulfil this issue? 🙂

Checklist

• - An issue already exists detailing the issue/or feature request that this PR fixes
• - All specs are formatted with crystal tool format spec src
• - Inline documentation has been added and/or updated
• - Lucky builds on docker with ./script/setup
• - All builds and specs pass on docker with ./script/test

[jwoertink]

Hey! Thanks for starting another PR. This one will require changing how the action is executed.

Currently when you generate the action, you'll get generated code like this:

UserQuery.find(user_id).delete
flash.success = "Deleted the record"
redirect Index

But that just calls delete directly on the model. Instead it should generate the proper DeleteOperation and implement that. It'll end up generating code like this:

record = UserQuery.find(user_id)
User::DeleteOperation.destroy(record) do |operation, deleted|
  flash.success = "Deleted the record"
  redirect Index
end

You'll just have to figure out the dynamic calls that will generate the proper code, and then how to test that the correct code is generated for the correct model.

[nodeMD]

Thank you @jwoertink! 💪 Really appreciate the guidance, it helps me understand how crystal and lucky is working 🙇
I've pushed the changes. Please take a look and review 🙂

[jwoertink]

Great work! Just one small change left that I just thought of, but the rest of it looks good. Thanks for doing this. I also noticed a few other things that I will open up some other issues on shortly 😄

[nodeMD]

Thanks for doing this. I also noticed a few other things that I will open up some other issues on shortly 😄

Thank you! 😃 Can't wait to give them a try 😁

[jwoertink]

🎉