Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 'multipart?' request helper #1495

Merged
merged 2 commits into from
May 17, 2021
Merged

Added 'multipart?' request helper #1495

merged 2 commits into from
May 17, 2021

Conversation

nodeMD
Copy link
Contributor

@nodeMD nodeMD commented May 14, 2021 •
edited by jwoertink
Loading

Purpose

Fixes #1494

Description

Adds 'multipart?' request helper

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@nodeMD nodeMD mentioned this pull request May 14, 2021
Closed
@matthewmcgarvey matthewmcgarvey linked an issue May 14, 2021 that may be closed by this pull request
Add new multipart? request helper #1494
Closed
jwoertink
jwoertink requested changes May 14, 2021
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like another great contribution! Just one small change to make sure we can catch a wider range.

src/lucky/request_type_helpers.cr Outdated Show resolved Hide resolved
@nodeMD nodeMD requested a review from jwoertink May 14, 2021 17:21
jwoertink
jwoertink approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for taking care of this.

spec/lucky/request_type_helper_spec.cr
@@ -71,7 +71,7 @@ describe Lucky::RequestTypeHelpers do
action = FakeAction.new
action.multipart?.should(be_false)

action.context.request.headers["Content-Type"] = "multipart/form-data"
action.context.request.headers["Content-Type"] = "multipart/form-data; boundary="
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice! 👍

@jwoertink jwoertink merged commit 2e60eb7 into luckyframework:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new multipart? request helper
3 participants
@nodeMD @jwoertink @CodeTestCreate