Updates lucky watch to emit to bin/ #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crystal convention is to emit binaries to
./binand since lucky scripts are inscript/now, I think moving this over will reduce clutter in a project root directory.Purpose
General cleanup
Checklist
[ ] - An issue already exists detailing the issue/or feature request that this PR fixes[ ] - All specs are formatted withcrystal tool format spec src[ ] - Inline documentation has been added and/or updated- Lucky builds on docker with
./script/setup- All builds and specs pass on docker with
./script/test- lucky-cli has been updated: Remove unnecessary .gitignore additions - start_server/*.dwarf lucky_cli#586