Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify accepted_format doc blocks #1234

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Clarify accepted_format doc blocks #1234

merged 1 commit into from
Aug 10, 2020

Conversation

stephendolan
Copy link
Member

Purpose

Revise the doc block for accepted_format to (hopefully) make it more clear.

Description

This was a result of research that was done for luckyframework/website#392

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@stephendolan stephendolan mentioned this pull request Aug 8, 2020
Merged
paulcsmith
paulcsmith approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@paulcsmith paulcsmith merged commit 9ed19a3 into luckyframework:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcsmith paulcsmith paulcsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephendolan @paulcsmith