Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ajax? helper to check only XMLHttpRequest presence #1134

Merged
merged 1 commit into from
May 12, 2020

Conversation

skojin
Copy link
Contributor

@skojin skojin commented May 7, 2020

Use ajax? in redirect helper instead of inline check

Fixes #1131

Checklist

  • [x ] - An issue already exists detailing the issue/or feature request that this PR fixes
  • [ x] - All specs are formatted with crystal tool format spec src
  • [ x] - Inline documentation has been added and/or updated
  • [ x] - Lucky builds on docker with ./script/setup
  • [ x] - All builds and specs pass on docker with ./script/test

Use ajax? in redirect helper instead of inline check

Fixes luckyframework#1131
Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @skojin!

@paulcsmith paulcsmith merged commit f279d93 into luckyframework:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lucky::RequestTypeHelpers#ajax? always false
2 participants