Adding a new method to action classes to return permitted param declarations #1122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is a precursor to #1070
Description
Before this PR there was no way to know what params have been defined on an Action class. Also interesting thing, calling something like
Users::Index::PARAM_DECLARATIONS
would throw an exception thatCrystal::Macros::TypeDeclaration
was undefined. I guess that constant only lives inside of macros...Well, now we have a method called
permitted_query_params
on the class. This will be useful for adding which params are allowed in a route when runninglucky routes
.Checklist
crystal tool format spec src
./script/setup
./script/test