Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for array in paginator #1108

Merged
merged 6 commits into from
Apr 16, 2020

Conversation

confact
Copy link
Contributor

@confact confact commented Apr 16, 2020

Purpose

Adding array support in paginator. Fixes #1106

Description

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@confact
Copy link
Contributor Author

confact commented Apr 16, 2020

@paulcsmith don't understand why i get that test error. That the db is not connected on only my two tests.

@paulcsmith paulcsmith changed the title added support for array in paginator Added support for array in paginator Apr 16, 2020
Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions. Once addressed this looks good to go!

Thanks for adding this :D

spec/paginator/backend_helpers_spec.cr Outdated Show resolved Hide resolved
spec/paginator/backend_helpers_spec.cr Outdated Show resolved Hide resolved
src/lucky/paginator/backend_helpers.cr Outdated Show resolved Hide resolved
src/lucky/paginator/backend_helpers.cr Outdated Show resolved Hide resolved
src/lucky/paginator/backend_helpers.cr Outdated Show resolved Hide resolved
Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 tiny suggestions then ready to go 🥳

src/lucky/paginator/backend_helpers.cr Outdated Show resolved Hide resolved
spec/paginator/backend_helpers_spec.cr Outdated Show resolved Hide resolved
@paulcsmith paulcsmith merged commit b54a92c into luckyframework:master Apr 16, 2020
@confact confact deleted the paginator-array branch April 17, 2020 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for arrays in paginator
3 participants