Lucky::Params and escape hatch methods (from_json/query/form/multipart) #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a simple delegate, but makes it easier to access just the query params if you need to. Part of the plan to add escape hatches to Lucky for more complex scenarios where you need to get the low-level constructs.
jkthorne
reviewed
Mar 19, 2020
paulcsmith
force-pushed
the
pcs/new-params-escape-hatches
branch
from
f0d49cc to
168f374
Compare
jwoertink
reviewed
Mar 19, 2020
jwoertink
reviewed
Mar 19, 2020
paulcsmith
force-pushed
the
pcs/new-params-escape-hatches
branch
from
168f374 to
7578a11
Compare
paulcsmith
force-pushed
the
pcs/new-params-escape-hatches
branch
from
7578a11 to
e25384b
Compare
jwoertink
reviewed
Mar 19, 2020
| end | ||
| rescue JSON::ParseException | ||
| raise Lucky::ParamParsingError.new(request) | ||
| private memoize def parsed_json : JSON::Any |
There was a problem hiding this comment.
Does this work? 😂 I didn't know that!
There was a problem hiding this comment.
Yup! It looks weird but macros before defs have to go between the private haha
jwoertink
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves documentation in Lucky::Params as well as adds some methods for interacting with the raw data more easily if needed: