Error: undefined method 'address' for Socket::UNIXAddress (compile-time type is Socket::Address+)

[bettinson]

Describe the bug
Type mismatch for Socket::UNIXAddress

To Reproduce
ip_address = context.request.remote_address.try(&.address) || "N/A"

from https://luckyframework.org/guides/http-and-routing/http-handlers#remoteiphandler

Screenshots/code

Error: undefined method 'address' for Socket::UNIXAddress (compile-time type is Socket::Address+) 

Fix

ip_address = context.request.remote_address.as(Socket::IPAddress).try(&.address) || "N/A"

Versions (please complete the following information):

• Lucky version 0.29.0
• Crystal version Crystal 1.2.2 (2021-11-10)
• OS: MacOS

[jwoertink]

Yeah, I feel like we should be able to update the handler to better handle this. You shouldn't have to do all the guessing and stuff with it

lucky/src/lucky/remote_ip_handler.cr

Lines 10 to 32 in 08a70e1

	class Lucky::RemoteIpHandler
	include HTTP::Handler
	def call(context)
	context.request.remote_address = fetch_remote_ip(context)
	call_next(context)
	end
	private def fetch_remote_ip(context : HTTP::Server::Context) : Socket::Address?
	request = context.request
	if x_forwarded = request.headers["X_FORWARDED_FOR"]?.try(&.split(',').first?).presence
	begin
	Socket::IPAddress.new(x_forwarded, 0)
	rescue Socket::Error
	# if the x_forwarded is not a valid ip address we fallback to request.remote_address
	request.remote_address
	end
	else
	request.remote_address
	end
	end
	end