Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec expectation have_delivered_emails #45

Merged
merged 3 commits into from
Dec 29, 2020

Conversation

matthewmcgarvey
Copy link
Member

Fixes #26

Refactored expectations code before adding new expectation. This asserts that some/any emails have been delivered.

I envision this expectation being updated to be more flexible. For instance, an override that takes in an email class that narrows down the check and then helper methods to specify who it was sent to and who was CC'd, etc.

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Looks good.

@matthewmcgarvey matthewmcgarvey merged commit 2c0a6f0 into master Dec 29, 2020
@matthewmcgarvey matthewmcgarvey deleted the matthewmcgarvey/issue26 branch December 29, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add have_delivered_emails expectation
2 participants