Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes luckyframework/avram_slugify#13
This pulls the entire
AvramSlugify
shard directly in to Avram asAvram::Slugify
. No usage or features have changed aside from the name scope. The main considerations for bringing this over areThe specs weren't copy/paste since the shard was using a
User
model that wasn't setup the same. I decided to just make a separate model for testing that.The only other main thing to consider was whether or not to make this an optional require. On the one hand, we could add it as its own module where you'd have to manually require it:
But then I thought... why? It doesn't interfere with your code by always having it. Crystal is pretty good at optimizing for code that's not being used.