Add random_order method to query objects #765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a proposal for the
random_order
implementation (#755).Initially, I tried to add a
:random
option toAvram::OrderBy
but a few things were bad about that approach:column
argument in the initializer, requiring thecolumn
attribute to be nilableAvram::OrderBy.new(nil, :random)
)That's why I decided to create an abstract class called
Avram::OrderByClause
and split out the two different order methods into two subclasses calledAvram::OrderBy
andAvram::OrderByRandom
. TheAvram::OrderBy
class could have been renamed toAvram::OrderByColumn
for consistency, but by keeping the old name, we're not breaking anything.Having multiple order by classes also will make it easier to add more order methods later on. Like ordering by an array for example, which is something I've needed in the past. For example, we could also add an
Avram::OrderByArray
class, generating the following clause:Which could look like: