Rename DeleteOperation#destroy to #delete #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
reviewed
Jul 13, 2021
Comment on lines
-95
to
-107
| def self.delete{% if with_bang %}!{% end %}(*args, **named_args{% if !with_bang %}, &block{% end %}) | ||
| {% verbatim do %} | ||
| {% raise <<-ERROR | ||
| DeleteOperations do not have a 'delete' method. | ||
|
|
||
| Try this... | ||
|
|
||
| ▸ Use 'destroy' to delete a record | ||
|
|
||
| ERROR | ||
| %} | ||
| {% end %} | ||
| end |
There was a problem hiding this comment.
We should leave this in, but name it destroy with a message like "destroy has been renamed to delete". Maybe with the type name or something so it's easy to find which ones you have to replace?
There was a problem hiding this comment.
I added it in, unfortunately I had to move the compilation error because @type was not the inherited type and it was a mess of macro code in the backtrace.
This is something that I hope can be removed in the future so I don't think it's a big deal.
matthewmcgarvey
force-pushed
the
destroy-to-delete
branch
from
a868083 to
5f67d46
Compare
matthewmcgarvey
force-pushed
the
destroy-to-delete
branch
from
5f67d46 to
9ac4b11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #694