Fix edge cases in migrator when using fill_existing_with with a boolean value #676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers a very edge case when performing migrations that imply adding a not null boolean column filling previous records with the false value.
In practice when performing this kind of modification
the migration fails as the fill_existing_with is not considered.
The patch fixes this particular case.
Note 1:
There is currently a way to bypass this by switching the former code to:
(add double quotes)
Note 2:
the resulting statement is now:
Is it correct? I didn't touch the logic in the BoolColumn, but I would assume that in theory it should be without single quotes. However, it seems that the same applies to FloatColumn as well...
Note 3:
Why is the default value for fill_existing_with in the add_macro nil and not :nothing?