Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Float64 to ColumnType #637

Merged
merged 6 commits into from
Mar 4, 2021

Conversation

brunto
Copy link
Contributor

@brunto brunto commented Feb 17, 2021

This is a solution for the issue: #636

@matthewmcgarvey
Copy link
Member

@brunto we're not going to remember why this type union was added. Could you add a spec that would fail before the change and this fixes?

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for adding these specs. It's good to have them in.

@brunto
Copy link
Contributor Author

brunto commented Feb 18, 2021

It's not finished I have one more test to add.

@brunto
Copy link
Contributor Author

brunto commented Feb 18, 2021

Ok now I'm done.

@jwoertink
Copy link
Member

@brunto now that you added that DOUBLE, I'm not sure if that type actually gets checked. I think it's just at runtime when you query on it, so you'd have to now add a spec that checks you can query on a DOUBLE column.

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the rest of it is fine. I'm not sure the best place to put the spec, but you can probably just add it here and say that we can query float columns defined as DOUBLE.

@brunto
Copy link
Contributor Author

brunto commented Feb 23, 2021

@jwoertink I just saw the "bucket" table. Maybe it's better to put the "Double" columns inside Bucket instead of Business?

@jwoertink
Copy link
Member

@brunto the buckets was used for Array stuff. I guess if you wanted to test a postgres array of double, then you can add an additional one there too, but otherwise what you have in business is fine.

@jwoertink
Copy link
Member

Ok, I pulled this in to one of my projects, and it seems to work. @brunto if you get a sec, can you rebase to make sure everything is good?

@brunto brunto force-pushed the add_float64_column_type branch from f7bcd57 to 3eaad57 Compare March 4, 2021 18:09
@brunto
Copy link
Contributor Author

brunto commented Mar 4, 2021

I rebased the code but I have one more spec to push.

@brunto
Copy link
Contributor Author

brunto commented Mar 4, 2021

@jwoertink Ok all is good now.

@brunto brunto requested a review from jwoertink March 4, 2021 18:38
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo hoo! Thanks for tackling this. 🎉

@jwoertink jwoertink merged commit c1ef94c into luckyframework:master Mar 4, 2021
@brunto brunto deleted the add_float64_column_type branch March 4, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants