-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Float64 to ColumnType #637
Add Float64 to ColumnType #637
Conversation
@brunto we're not going to remember why this type union was added. Could you add a spec that would fail before the change and this fixes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for adding these specs. It's good to have them in.
It's not finished I have one more test to add. |
Ok now I'm done. |
@brunto now that you added that DOUBLE, I'm not sure if that type actually gets checked. I think it's just at runtime when you query on it, so you'd have to now add a spec that checks you can query on a DOUBLE column. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the rest of it is fine. I'm not sure the best place to put the spec, but you can probably just add it here and say that we can query float columns defined as DOUBLE
.
@jwoertink I just saw the "bucket" table. Maybe it's better to put the "Double" columns inside Bucket instead of Business? |
@brunto the buckets was used for Array stuff. I guess if you wanted to test a postgres array of double, then you can add an additional one there too, but otherwise what you have in business is fine. |
Ok, I pulled this in to one of my projects, and it seems to work. @brunto if you get a sec, can you rebase to make sure everything is good? |
f7bcd57
to
3eaad57
Compare
I rebased the code but I have one more spec to push. |
@jwoertink Ok all is good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woo hoo! Thanks for tackling this. 🎉
This is a solution for the issue: #636