Load correct has_one association with lazy loading #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robacarp
approved these changes
Dec 29, 2020
matthewmcgarvey
force-pushed
the
bug/has-one-lazy-loading
branch
from
23921a1 to
5abdc8a
Compare
jwoertink
added a commit
that referenced
this pull request
Dec 29, 2020
jwoertink
added a commit
that referenced
this pull request
Dec 30, 2020
Patching #581. Bumping versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was still depending on the query being mutated instead of immutable so it was always loading the first association in the database. This only affected code that was using lazy loading (by enabling it or using the bang methods).