Allow insert giving default value #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkthorne
reviewed
Nov 19, 2020
| @@ -421,6 +421,14 @@ describe "Avram::SaveOperation" do | |||
| end | |||
| end | |||
|
|
|||
| it "allows supplying a value that matches the default" do | |||
| result = Company::SaveOperation.create!(sales: 0_i64, earnings: 0_i64) | |||
There was a problem hiding this comment.
shouldnt this be a float?
result = Company::SaveOperation.create!(sales: 0_i64, earnings: 0_f64)
There was a problem hiding this comment.
Oya, I guess you're right. The type extensions have methods for doing the conversion, luckily!
There was a problem hiding this comment.
TIL. I am surprised that worked but it makes sense.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #539
Does not filter out unchanged attributes, only nils, on inserting. This allows creating a model with the same value as the default.