Remove unique filter of where clauses #518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #487
With the addition of
OR
to the query builder, where clauses can no longer be uniquely filtered because two clauses are not equal just because they have they same condition, they could be separated by anOR
and affect the outcome if removed. For example, these two clauses are not the same but the current query builder would turn the first into the second because of the way it checks for uniqueness:This will not affect any queries negatively as truly duplicate conditions are handled as expected by Postgres.