Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't preload through association of has_many on count #509

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Don't preload through association of has_many on count #509

merged 1 commit into from
Oct 30, 2020

Conversation

matthewmcgarvey
Copy link
Member

Fixes #508

jwoertink
jwoertink approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah! 😂 that makes sense. We don't need those records since we're just returning the count.

@matthewmcgarvey matthewmcgarvey merged commit 3546039 into luckyframework:master Oct 30, 2020
@matthewmcgarvey matthewmcgarvey deleted the has-many-through-count branch October 30, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

has_many through associations preload through association on select count call
2 participants
@matthewmcgarvey @jwoertink