Add support for optional arrays #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
reviewed
Sep 25, 2020
| %from_db.as({{column[:type]}}) | ||
| {% end %} | ||
| def {{column[:name]}} : {{column[:type]}}{{(column[:nilable] ? "?" : "").id}} | ||
| {{ db_type }}::Lucky.from_db!(@{{column[:name]}}) |
There was a problem hiding this comment.
I think they just use the default from_db! coming from Avram::Type https://github.com/luckyframework/avram/blob/master/src/avram/type.cr#L6
| @@ -112,18 +112,17 @@ class Avram::Migrator::AlterTableStatement | |||
| end | |||
|
|
|||
| macro add(type_declaration, index = false, using = :btree, unique = false, default = nil, fill_existing_with = nil, **type_options) | |||
| {% if type_declaration.type.is_a?(Union) %} | |||
| {% type = type_declaration.type.types.first %} | |||
| {% type = type_declaration.type %} | |||
| it "handles optional Array" do | ||
| BucketBox.create &.numbers(nil) | ||
| bucket = BucketQuery.new.last | ||
| bucket.numbers.should be_nil |
There was a problem hiding this comment.
I'm pretty sure it works, but just for peace of mind, can you add to this spec where we take this bucket and update it to have an empty array? Or maybe add another spec in here that just tests a SaveOperation can have a nilable array but be updated to an empty array?
jwoertink
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #470
There are a couple of bugs that are fixed by these changes: