Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using fill_existing_with and nilable columns #452

Merged

Conversation

matthewmcgarvey
Copy link
Member

Fixes #421

This allows users to add optional columns and choosing to fill any existing columns with a value. Before, if you provided fill_existing_with it forced the column to be non null.

Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thank you :D

@paulcsmith paulcsmith merged commit 18fc522 into luckyframework:master Sep 14, 2020
@matthewmcgarvey matthewmcgarvey deleted the fill-existing-with-nilable branch September 14, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fill_existing_with Overrides Nullable Column Unexpectedly
2 participants