Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build_attributes to box model #449

Merged
merged 4 commits into from
Aug 29, 2020
Merged

Add build_attributes to box model #449

merged 4 commits into from
Aug 29, 2020

Conversation

Xosmond
Copy link
Contributor

@Xosmond Xosmond commented Aug 29, 2020

Discussion on #439

This PR is for adding build_attributes to box model.

@Xosmond Xosmond mentioned this pull request Aug 29, 2020
Closed
jwoertink
jwoertink approved these changes Aug 29, 2020
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this is perfect! I left a little comment on the spec, but otherwise I think we can merge this in 👍 Thanks for working on this!

spec/box_spec.cr Outdated Show resolved Hide resolved
@jwoertink jwoertink merged commit d18a015 into luckyframework:master Aug 29, 2020
@jwoertink
Copy link
Member

Awesome! good call on that sequences. This is gonna be a great addition. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xosmond @jwoertink