Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added count method for associations #392

Merged
merged 6 commits into from
Aug 10, 2020

Conversation

confact
Copy link
Contributor

@confact confact commented Jun 15, 2020

What this do right now is to just make it easier for calling select_count on associations of has_many.

It works all fine for simple associations.

Closes #388

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty cool. I dig it 👍

Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Thanks @confact

@paulcsmith paulcsmith merged commit 4178573 into luckyframework:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

have an nice way to count associations
3 participants