Fixing clone for distincts #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istinct from queries. Fixes #284
jwoertink
commented
Dec 20, 2019
paulcsmith
reviewed
Jan 3, 2020
|
Oh yeah I like that! I think a getter would be great
… On Jan 3, 2020, at 11:48 AM, Jeremy Woertink ***@***.***> wrote:
@jwoertink commented on this pull request.
In src/avram/query_builder.cr:
> @@ -112,8 +114,16 @@ class Avram::QueryBuilder
self
end
- private def distinct?
- @distinct || @distinct_on
+ def distinct?
+ @distinct || has_distinct_on?
+ end
+
+ def has_distinct_on?
+ ***@***.***_on
+ end
+
+ def raw_distinct_on
I can access raw_distinct_on from a separate object. This is so I don't do something ***@***.***_on. I could just make a getter for that and call other_query.distinct_on if that works better.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #284
I had to take off the private and break out the methods so that way I had access to the distincts on the query being merged in.