Fixing query with has_one #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
commented
Oct 15, 2019
|
@paulcsmith if you have a few min, I need to get back on this one. Maybe a second set of eyes would be great. Thanks! |
|
@jwoertink Could you rebase and push? I'll try to take a look this evening! Thanks for the ping :D |
|
Alright, this is a long time coming 😅 It took me a min to remember what all is going on here, but it's all looking good now. |
jwoertink
commented
Feb 19, 2020
| @@ -11,7 +11,7 @@ module Avram::Associations::HasOne | |||
| {% end %} | |||
|
|
|||
| {% unless foreign_key %} | |||
| {% foreign_key = "#{@type.name.underscore}_id".id %} | |||
| {% foreign_key = "#{@type.name.underscore.split("::").last.id}_id".id %} | |||
There was a problem hiding this comment.
This was fixed under the has_many a long time ago, so this now fixes it for the has_one
|
It still says WIP so holding off on merging just in case you wanted to do something else. Feel free to merge when you’re ready |
|
oh, oops! Ok. I'll take one last look over it, but I'm pretty sure it's ready to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223
This fixes 2 main issues with the
has_one:has_onewhen your model is namespaced