Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compile-time error to catch use of before in SaveOperation. #240

Merged
merged 3 commits into from
Sep 17, 2019
Merged

Add compile-time error to catch use of before in SaveOperation. #240

merged 3 commits into from
Sep 17, 2019

Conversation

jwoertink
Copy link
Member

Fixes #235

Screen Shot 2019-09-17 at 2 58 54 PM

paulcsmith
paulcsmith reviewed Sep 17, 2019
View reviewed changes
Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny suggestion. LGTM when you're ready

src/avram/callbacks.cr Outdated Show resolved Hide resolved
@jwoertink jwoertink merged commit 7403036 into master Sep 17, 2019
@jwoertink jwoertink deleted the issues/235 branch September 17, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcsmith paulcsmith paulcsmith left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add nice error if you accidentally use “before” in operations
2 participants
@jwoertink @paulcsmith