Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think this query_each would fail #741

Closed
jwoertink opened this issue Oct 9, 2021 · 0 comments · Fixed by #750
Closed

I think this query_each would fail #741

jwoertink opened this issue Oct 9, 2021 · 0 comments · Fixed by #750
Labels
clarify api Rename/remove/add something to make the API easier to understand needs investigation A possible bug / better docs needed. Investigate further

Comments

@jwoertink
Copy link
Member

{% for crystal_db_alias in [:exec, :scalar, :query, :query_all, :query_one, :query_one?, :query_each] %}

In crystal-db the query_each method requires a block

https://github.com/crystal-lang/crystal-db/blob/a25f33611c15b19b365eeba3ce4d585909d93566/src/db/query_methods.cr#L268

But in the first case, no block is defined. The second instance does define a block, so that one is probably fine.

@jwoertink jwoertink added clarify api Rename/remove/add something to make the API easier to understand needs investigation A possible bug / better docs needed. Investigate further labels Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarify api Rename/remove/add something to make the API easier to understand needs investigation A possible bug / better docs needed. Investigate further
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant