-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #407: Show number of hardlinks for lsd -l #459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few minor changes.
I was thinking we could change the name to |
Similar to changing |
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
==========================================
- Coverage 84.58% 84.46% -0.12%
==========================================
Files 35 36 +1
Lines 3353 3379 +26
==========================================
+ Hits 2836 2854 +18
- Misses 517 525 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things that you missed.
src/flags/blocks.rs
Outdated
Block::Name, | ||
Block::Links, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No links by default
Block::Name, | |
Block::Links, | |
Block::Name, |
src/color.rs
Outdated
m.insert(Elem::Links { valid: true }, Colour::Fixed(134)); | ||
m.insert(Elem::Links { valid: false }, Colour::Fixed(222)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could reuse the Inode
colors
m.insert(Elem::Links { valid: true }, Colour::Fixed(134)); | |
m.insert(Elem::Links { valid: false }, Colour::Fixed(222)); | |
m.insert(Elem::Links { valid: true }, Colour::Fixed(13)); | |
m.insert(Elem::Links { valid: false }, Colour::Fixed(245)); |
Awesome, thanks a lot! |
please add |
Added in #808 |
TODO
cargo fmt