Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add types to polyfill #147

Merged
merged 1 commit into from
May 19, 2023
Merged

fix: add types to polyfill #147

merged 1 commit into from
May 19, 2023

Conversation

stuft2
Copy link
Contributor

@stuft2 stuft2 commented Oct 25, 2022 •
edited
Loading

Type definition resolution isn't working for me when importing cross-fetch/polyfill. Adding the types property to the package.json file resolves this issue.

import 'cross-fetch/polyfill'
//  error TS2304: Cannot find name 'Request'.

@stuft2 stuft2 changed the title Add types to polyfill fix: add types to polyfill Oct 25, 2022
@stuft2 stuft2 mentioned this pull request Jan 30, 2023
Closed
@lquixada lquixada force-pushed the main branch 2 times, most recently from c7aa351 to 5e3d301 Compare April 23, 2023 22:32
@lquixada lquixada merged commit 5f452e0 into lquixada:main May 19, 2023
@lquixada
Copy link
Owner

@stuft2 thanks for the PR!

@stuft2 stuft2 deleted the patch/types branch May 20, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lquixada lquixada lquixada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuft2 @lquixada