All update modes to call to_s + coerce better. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align with upcoming PR logstash-plugins#75 Bump CHANGELOG to 3.2.3
guyboertje
force-pushed
the
fix/to_s-coerce
branch
from
671878d to
f5422d9
Compare
jsvd
reviewed
Sep 5, 2018
| end | ||
|
|
||
| def test_for_inclusion(event, override) | ||
| # Skip translation in case @destination iterate_on already exists and @override is disabled. | ||
| return false if event.include?(@destination) && !override | ||
| return false if !override && event.include?(@destination) |
There was a problem hiding this comment.
Its better to check the boolean before making the more expensive include? call, no?
| @@ -25,7 +25,7 @@ def update(event) | |||
| inner = event.get(nested_field) | |||
| next if inner.nil? | |||
| matched = [true, nil] | |||
| @lookup.fetch_strategy.fetch(inner, matched) | |||
| @lookup.fetch_strategy.fetch(inner.to_s, matched) | |||
There was a problem hiding this comment.
these changes should be accompanied by a couple of tests, maybe? like showing how integer keys get coerced in to strings and an array gets coerced into its first element
jsvd
reviewed
Sep 5, 2018
CHANGELOG.md
Outdated
| @@ -1,4 +1,5 @@ | |||
| ## master | |||
| ## 3.2.3 | |||
| - Fix to align with docs - looked-up values are always strings. Coerce better. | |||
jsvd
approved these changes
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align with upcoming PR #75
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/