Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve tint.Err attribute key #66

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

kwargs
Copy link
Contributor

@kwargs kwargs commented Jul 10, 2024

We do not always have control over how attribute names are defined. However, it is beneficial to highlight errors in development logs for better visibility.

For example, we heavily rely on Temporal, and modifying attribute names in that context appears inconsistent.

2024-07-10T13:08:55Z ERR Activity error. 
   Namespace=dev-kwargs TaskQueue= WorkerID=1@kwargs- 
   WorkflowID=7bda7d48 ActivityType=DeleteCluster Attempt=8 
   err="list clusters with name filter:  rpc error: code = PermissionDenied desc = Permission denied"

We do not always have control over how attribute names are defined.
However, it is beneficial to highlight errors in development logs for better visibility.
@kwargs kwargs force-pushed the preserve-err-name branch from 33ce023 to 2f41f32 Compare July 10, 2024 14:45
@lmittmann lmittmann changed the title Preserve the 'err' Attribute Name Preserve tint.Err attribute key Jul 10, 2024
@lmittmann lmittmann merged commit 368de75 into lmittmann:main Jul 10, 2024
2 checks passed
@lmittmann
Copy link
Owner

lmittmann commented Jul 10, 2024

thank you for the improvement

@kwargs
Copy link
Contributor Author

kwargs commented Jul 10, 2024

Thank you so much for your library, it's absolutely awesome!✨

abs3ntdev pushed a commit to abs3ntdev/gspot that referenced this pull request Jul 11, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/lmittmann/tint](https://github.com/lmittmann/tint) | require | patch | `v1.0.4` -> `v1.0.5` |

---

### Release Notes

<details>
<summary>lmittmann/tint (github.com/lmittmann/tint)</summary>

### [`v1.0.5`](https://github.com/lmittmann/tint/releases/tag/v1.0.5)

[Compare Source](lmittmann/tint@v1.0.4...v1.0.5)

#### What's Changed

-   Preserve `tint.Err` attribute key by [@&#8203;kwargs](https://github.com/kwargs) in lmittmann/tint#66

#### New Contributors

-   [@&#8203;kwargs](https://github.com/kwargs) made their first contribution in lmittmann/tint#66

**Full Changelog**: lmittmann/tint@v1.0.4...v1.0.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: Renovate Bot <[email protected]>
Reviewed-on: https://git.asdf.cafe/abs3nt/gspot/pulls/19
renovate bot referenced this pull request in jippi/dottie Jul 12, 2024
#63)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/lmittmann/tint](https://togithub.com/lmittmann/tint) |
`v1.0.4` -> `v1.0.5` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2flmittmann%2ftint/v1.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2flmittmann%2ftint/v1.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2flmittmann%2ftint/v1.0.4/v1.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2flmittmann%2ftint/v1.0.4/v1.0.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>lmittmann/tint (github.com/lmittmann/tint)</summary>

### [`v1.0.5`](https://togithub.com/lmittmann/tint/releases/tag/v1.0.5)

[Compare
Source](https://togithub.com/lmittmann/tint/compare/v1.0.4...v1.0.5)

#### What's Changed

- Preserve `tint.Err` attribute key by
[@&#8203;kwargs](https://togithub.com/kwargs) in
[https://github.com/lmittmann/tint/pull/66](https://togithub.com/lmittmann/tint/pull/66)

#### New Contributors

- [@&#8203;kwargs](https://togithub.com/kwargs) made their first
contribution in
[https://github.com/lmittmann/tint/pull/66](https://togithub.com/lmittmann/tint/pull/66)

**Full Changelog**:
lmittmann/tint@v1.0.4...v1.0.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* */8 * * *" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/jippi/dottie).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants