[Github] Add LLVM Premerge Checks to the watchlist #120230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM Premerge Checks is running on the new GCP cluster. Tracking its metrics will allow us to determine the stability of the presubmit and make sure the new infra is working as intended. Signed-off-by: Nathan Gauër <[email protected]>
|
✅ With the latest revision this PR passed the Python code formatter. |
Signed-off-by: Nathan Gauër <[email protected]>
boomanaiden154
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Tested manually since we don't have any automated testing:
[JobMetrics(job_name='Check code formatting', queue_time=6, run_time=172, status=1, created_at_ns=1734474477000000000, workflow_id=12382528649), JobMetrics(job_name='LLVM Premerge Checks', queue_time=667, run_time=1013, status=1, created_at_ns=1734472175000000000, workflow_id=12382027516)]
Fake uploaded 2 metrics
[JobMetrics(job_name='Check code formatting', queue_time=6, run_time=172, status=1, created_at_ns=1734474605000000000, workflow_id=12382556504), JobMetrics(job_name='Check code formatting', queue_time=5, run_time=228, status=1, created_at_ns=1734474504000000000, workflow_id=12382535076)]
Fake uploaded 2 metrics
No metrics found to upload.
No metrics found to upload.
[JobMetrics(job_name='Check code formatting', queue_time=6, run_time=178, status=1, created_at_ns=1734474704000000000, workflow_id=12382576218)]
Fake uploaded 1 metrics
[JobMetrics(job_name='Check code formatting', queue_time=6, run_time=176, status=1, created_at_ns=1734474735000000000, workflow_id=12382582860)]
Fake uploaded 1 metrics
[JobMetrics(job_name='Check code formatting', queue_time=7, run_time=170, status=0, created_at_ns=1734474813000000000, workflow_id=12382598716), JobMetrics(job_name='Check code formatting', queue_time=6, run_time=181, status=1, created_at_ns=1734474789000000000, workflow_id=12382593396)]
Fake uploaded 2 metrics
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
[JobMetrics(job_name='Check code formatting', queue_time=5, run_time=186, status=1, created_at_ns=1734475015000000000, workflow_id=12382643443)]
Fake uploaded 1 metrics
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
No metrics found to upload.
[JobMetrics(job_name='Check code formatting', queue_time=7, run_time=184, status=1, created_at_ns=1734475208000000000, workflow_id=12382681715)]
Fake uploaded 1 metrics
[JobMetrics(job_name='LLVM Premerge Checks', queue_time=5, run_time=1801, status=0, created_at_ns=1734473648000000000, workflow_id=12382347323)]
Fake uploaded 1 metrics
Seems like everything is working, so LGTM. We'll have to modify the dashboard to add everything. To get this deployed we might also need to delete the pod to force it to pull the new container version. Theoretically we should always pull the container when recreating the pod, but I'm not sure if it's explicitly setup that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM Premerge Checks is running on the new GCP cluster. Tracking its metrics will allow us to determine the stability of the presubmit and make sure the new infra is working as intended.