-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security] Refactor gitMutex key naming in chaoscenter/graphql/server/pkg/gitops/git-lock.go #4810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-lock.go Signed-off-by: ParkChangSun <[email protected]>
Signed-off-by: ParkChangSun <[email protected]>
Signed-off-by: ParkChangSun <[email protected]>
This pr solved below security issues |
namkyu1999
changed the title
refactor: gitMutex key naming in chaoscenter/graphql/server/pkg/gitops/git-lock.go
[Security] Refactor gitMutex key naming in chaoscenter/graphql/server/pkg/gitops/git-lock.go
Aug 4, 2024
namkyu1999
approved these changes
Aug 4, 2024
Saranya-jena
approved these changes
Aug 9, 2024
amityt
approved these changes
Aug 9, 2024
kwx4957
pushed a commit
to kwx4957/litmus
that referenced
this pull request
Sep 1, 2024
…/pkg/gitops/git-lock.go (litmuschaos#4810) * fix: gitMutex key naming in chaoscenter/graphql/server/pkg/gitops/git-lock.go Signed-off-by: ParkChangSun <[email protected]> * fix: log key in chaoscenter/graphql/server/pkg/gitops/git-lock.go Signed-off-by: ParkChangSun <[email protected]> * fix: log key in chaoscenter/graphql/server/pkg/gitops/git-lock.go Signed-off-by: ParkChangSun <[email protected]> --------- Signed-off-by: ParkChangSun <[email protected]> Co-authored-by: Saranya Jena <[email protected]> Co-authored-by: Amit Kumar Das <[email protected]>
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Sep 7, 2024
…/pkg/gitops/git-lock.go (litmuschaos#4810) * fix: gitMutex key naming in chaoscenter/graphql/server/pkg/gitops/git-lock.go Signed-off-by: ParkChangSun <[email protected]> * fix: log key in chaoscenter/graphql/server/pkg/gitops/git-lock.go Signed-off-by: ParkChangSun <[email protected]> * fix: log key in chaoscenter/graphql/server/pkg/gitops/git-lock.go Signed-off-by: ParkChangSun <[email protected]> --------- Signed-off-by: ParkChangSun <[email protected]> Co-authored-by: Saranya Jena <[email protected]> Co-authored-by: Amit Kumar Das <[email protected]> Signed-off-by: andoriyaprashant <[email protected]>
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Sep 7, 2024
…/pkg/gitops/git-lock.go (litmuschaos#4810) * fix: gitMutex key naming in chaoscenter/graphql/server/pkg/gitops/git-lock.go Signed-off-by: ParkChangSun <[email protected]> * fix: log key in chaoscenter/graphql/server/pkg/gitops/git-lock.go Signed-off-by: ParkChangSun <[email protected]> * fix: log key in chaoscenter/graphql/server/pkg/gitops/git-lock.go Signed-off-by: ParkChangSun <[email protected]> --------- Signed-off-by: ParkChangSun <[email protected]> Co-authored-by: Saranya Jena <[email protected]> Co-authored-by: Amit Kumar Das <[email protected]> Signed-off-by: andoriyaprashant <[email protected]>
sagnik3788
pushed a commit
to sagnik3788/litmus
that referenced
this pull request
Oct 5, 2024
…/pkg/gitops/git-lock.go (litmuschaos#4810) * fix: gitMutex key naming in chaoscenter/graphql/server/pkg/gitops/git-lock.go Signed-off-by: ParkChangSun <[email protected]> * fix: log key in chaoscenter/graphql/server/pkg/gitops/git-lock.go Signed-off-by: ParkChangSun <[email protected]> * fix: log key in chaoscenter/graphql/server/pkg/gitops/git-lock.go Signed-off-by: ParkChangSun <[email protected]> --------- Signed-off-by: ParkChangSun <[email protected]> Co-authored-by: Saranya Jena <[email protected]> Co-authored-by: Amit Kumar Das <[email protected]> Signed-off-by: sagnik3788 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Changed the variable name "key" in function Lock & Unlock in chaoscenter/graphql/server/pkg/gitops/git-lock.go into "url".
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
N/A
Special notes for your reviewer: