-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ususual space around project selection card #4676
fix ususual space around project selection card #4676
Conversation
Signed-off-by: JanhaviAlekar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this class, not necessary but because flex-grow: 0
is a default value.
Signed-off-by: JanhaviAlekar <[email protected]>
Removed it |
Hi @JanhaviAlekar, can you check build-pipelines? |
@JanhaviAlekar can you resolve the conflicts? We can merge it afterwards. |
Signed-off-by: Janhavi Alekar <[email protected]>
Done |
* fix ususual space around project selection card Signed-off-by: JanhaviAlekar <[email protected]> * Removed .grow class Signed-off-by: JanhaviAlekar <[email protected]> * removing grow class Signed-off-by: JanhaviAlekar <[email protected]> --------- Signed-off-by: JanhaviAlekar <[email protected]> Signed-off-by: Janhavi Alekar <[email protected]> Co-authored-by: Namkyu Park <[email protected]> Signed-off-by: andoriyaprashant <[email protected]>
* fix ususual space around project selection card Signed-off-by: JanhaviAlekar <[email protected]> * Removed .grow class Signed-off-by: JanhaviAlekar <[email protected]> * removing grow class Signed-off-by: JanhaviAlekar <[email protected]> --------- Signed-off-by: JanhaviAlekar <[email protected]> Signed-off-by: Janhavi Alekar <[email protected]> Co-authored-by: Namkyu Park <[email protected]> Signed-off-by: andoriyaprashant <[email protected]>
* fix ususual space around project selection card Signed-off-by: JanhaviAlekar <[email protected]> * Removed .grow class Signed-off-by: JanhaviAlekar <[email protected]> * removing grow class Signed-off-by: JanhaviAlekar <[email protected]> --------- Signed-off-by: JanhaviAlekar <[email protected]> Signed-off-by: Janhavi Alekar <[email protected]> Co-authored-by: Namkyu Park <[email protected]> Signed-off-by: sagnik3788 <[email protected]>
fixes #4675
Proposed changes
Enhancing user experience by removing unusual space around project selection card
results :
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.